Open
Conversation
_app_for_name() used to use an equality operator to check for a match, meaning that you had to know the full and exact name of the app you wished to invoke. This function now does a find operation on the app.name string, allowing for a partial match of the name. This has the limitation, of course, of only returning the first match.
Author
|
It's worth noting that this change should be immediately merge-able without affecting existing implementations, as this does not change the function signature nor the return value. Most notably that it will not change the matched app for an exact match. |
metagrapher
changed the title
Owner
|
@metagrapher thanks for the contribution! If we're going to go with fuzzy matching, I'm trying to think through other scenarios here. Would we want to potentially ignore case as well with something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_app_for_name() used to use an equality operator to check for a match, meaning that you had to know the full and exact name of the app you wished to invoke.
This function now does a find operation on the app.name string, allowing for a partial match of the app name.